Add {Assert,Refute}Match
OnlyRegexpLiteral
config
#323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssertMatch
&RefuteMatch
enforceand
respectively, which use
=~
under the hood. This makes the cops highly susceptible to false positives, in cases where the matcher object responds tomatch?
, but not to=~
or cases where the matcher object does also respond to
=~
, but in an incompatible wayGiven RuboCop doesn't have runtime type information, the only case we can reliably identify is the case where a
Regexp
literal is used.Therefore, this adds an
OnlyRegexpLiteral
config (false by default), which consumers can enable if their codebase has many false positives.This provides a way for consumers to address #310, without changing the cop's behavior for everyone.
As part of making this change, a common module is extracted for the implementations of
AssertMatch
andRefuteMatch
, which are largely identical.Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number]
(if the related issue exists).I wasn't sure about this, since this PR isn't changing/fixing the default behavior, it's just adding an option which allows consumers to fix the behavior.
master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.Likewise, I tagged the change as "new", since it's an new option, and consumers have to opt-in to the new behavior. We could eventually make it the default though.